brew.sh: enforce HOMEBREW_FORCE_BREW_WRAPPER more strictly
#20400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`HOMEBREW_FORCE_BREW_WRAPPER` can be used as a security/compliance feature, but allowing it to be disabled by setting `HOMEBREW_NO_FORCE_BREW_WRAPPER` leaves a pretty large hole in it that allows it to be sidestepped. Let's fix that by actually checking the path of the process that called `brew`, and the verify that that path matches the configured value of `HOMEBREW_NO_FORCE_BREW_WRAPPER`.
MikeMcQuaid
reviewed
Aug 11, 2025
Co-authored-by: MikeMcQuaid <[email protected]>
These need to go through a deprecation cycle, so let's just add comments preparing it for that.
This now requires `HOMEBREW_DISABLE_NO_FORCE_BREW_WRAPPER` to be unset. If it is set (but only in a `brew.env` file), then we use the new functionality of checking the path of the parent process.
MikeMcQuaid
reviewed
Aug 13, 2025
MikeMcQuaid
reviewed
Aug 13, 2025
carlocab
force-pushed
the
stricter-brew-wrappers
branch
from
7634d1d to
ead3af9
Compare
MikeMcQuaid
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?HOMEBREW_FORCE_BREW_WRAPPERcan be used as a security/compliancefeature, but allowing it to be disabled by setting
HOMEBREW_NO_FORCE_BREW_WRAPPERleaves a pretty large hole in it thatallows it to be sidestepped.
Let's fix that by actually checking the path of the process that called
brew, and the verify that that path matches the configured value ofHOMEBREW_NO_FORCE_BREW_WRAPPER.